[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: omerap12
Once this PR has been reviewed and has the lgtm label, please assign spzala for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Hi @omerap12. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Thanks @omerap12 for the PR.
Upon 2nd thought, I think we probably would like to be able to toggle memory-mlock=true|false even after its graduation. So it may not be a good use case for feature gate. Should we just migrate --experimental-memory-mlock flag to --memory-mlock without adding the feature gate @serathius @ahrtr ?

Should we just migrate --experimental-memory-mlock flag to --memory-mlock without adding the feature gate

Agreed. Similarly, both --experimental-memory-mlock and --memory-mlock should work in 3.6, and remove the experimental flag in 3.7.

Agreed

Understood. Ill adjust.

@omerap12 are you still working on this PR? @siyuanfoundation please feel free to take over if there is no response this week.

@omerap12 are you still working on this PR? @siyuanfoundation please feel free to take over if there is no response this week.

Hi! I raised #19096 and want to check if it’s okay before starting work on this issue since they are similar. If anyone wants to work on this, please assign it to yourself. If not, I’ll work on it after #19096 is approved.